Repository navigation
Conversation
β¦for a domain literal starting with whitespace
|
All commit authors signed the Contributor License Agreement. |
Codex Review Summary: β CompletedThis comment shows the latest Codex review activity on this pull request.
βΉοΈ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with π while any review is running, comments if it has suggestions, and reacts with π once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_get_ptext_to_endcharsreadposbefore assigning it when its input started with whitespace, because the first word from_wsp_splitterwas then empty and the loop body never ran. This could happen when aMessage-ID,ReferencesorIn-Reply-Toheader has a domain literal such as<a@[ x]>. Theif not valueguard added for gh-134152 is replaced by a check on the empty first word, which covers both cases. The header now parses the same way as<a@[x ]>, as an obsolete id-right with anObsoleteHeaderDefect.Note: the open refactor in gh-152710 edits the same lines, so whichever merges second will need a small rebase.