Repository navigation
Conversation
…keyword arguments Add an invalid_kwarg alternative so that `f(a=x := 1)` reports "cannot use named expression without parentheses here" instead of the generic "invalid syntax", reusing the message already used for `assert x := 1`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
This adds an alternative to
invalid_kwargthat matchesNAME '=' NAME ':=' expressionand reuses the message already used forassert x := 1. Becauseinvalid_kwargis used for all keyword arguments, this also covers keywords after positional,*argsor**kwargsarguments, and class keywords such asclass C(metaclass=x := type).Unlike the patch suggested in the issue, the rule lives in
invalid_kwarginstead ofinvalid_expression, so the existing messages for other cases (e.g. lambda and conditional expressions) are unchanged. Non-name targets likef(a=x.y := 1)keep the current message, since adding parentheses would not fix them.Two existing tests in
test_named_expressions(invalid_09andinvalid_10) asserted the generic "invalid syntax" message for exactly these inputs; they now expect the new message. New cases were added totest_syntax.Related: #161927 handles the lambda case (gh-137570) with the same message.