Skip to content

gh-161932: Skip test_ssl ECH test with FIPS enabled - #161939

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:ssl_ech_fips
Nov 14, 2026
Merged

vstinner merged 1 commit into
python:mainfrom
vstinner:ssl_ech_fips

Conversation

@vstinner

@vstinner vstinner commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

ECH hasn't been included in FIPS mode in OpenSSL so far.

ECH hasn't been included in FIPS mode in OpenSSL so far.
@vstinner

Copy link
Copy Markdown
Member Author

Without the change, OPENSSL_FORCE_FIPS_MODE=1 ./python -m test test_ssl -m ECHTests -v fails on Fedora 45 with OpenSSL 4.0.3 with (see the issue for details):

ERROR: test_grease (test.test_ssl.ECHTests.test_grease)
ERROR: test_outer_alpn_without_ech_config (test.test_ssl.ECHTests.test_outer_alpn_without_ech_config)

With the change, the test pass successfully.

cc @picnixz

See #161739 for the previous test_hashlib fix for FIPS mode.

@picnixz

picnixz commented Nov 13, 2026

Copy link
Copy Markdown
Member

Yeah, I don't mind skipping tests that fail on some FIPS builds rather than trying to hunt the reason why the fail. If someone sees wrong things happening, they'll just report it.

@vstinner
vstinner merged commit af106b8 into python:main Nov 14, 2026
58 of 59 checks passed
@vstinner
vstinner deleted the ssl_ech_fips branch November 14, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir topic-SSL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants