Repository navigation
[3.14] gh-158907: Do not send proxy credentials to a direct origin on 407 (GH-158956) - #161920
Open
miss-islington wants to merge 1 commit into
Open
miss-islington wants to merge 1 commit into
miss-islington wants to merge 1 commit into
Conversation
…407 (pythonGH-158956) * pythongh-158907: Do not send proxy credentials to a direct origin on 407 ProxyBasicAuthHandler and ProxyDigestAuthHandler looked up passwords with the scheme-less origin host, so an HTTP 407 could match credentials stored for HTTPS and retry in cleartext. --------- (cherry picked from commit ab48ba8) Co-authored-by: rajorin <167426833+rajorin@users.noreply.github.com> Co-authored-by: Senthil Kumaran <senthil@python.org>
|
The following commit authors need to sign the Contributor License Agreement: |
This was referenced Nov 13, 2026
orsenthil
approved these changes
Nov 13, 2026
orsenthil
enabled auto-merge (squash)
November 13, 2026 01:44
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProxyBasicAuthHandler and ProxyDigestAuthHandler looked up passwords with the scheme-less origin host, so an HTTP 407 could match credentials stored for HTTPS and retry in cleartext.
(cherry picked from commit ab48ba8)
Co-authored-by: rajorin 167426833+rajorin@users.noreply.github.com
Co-authored-by: Senthil Kumaran senthil@python.org