Repository navigation
gh-159637: Fix renaming an attribute to a prefixed name in minidom - #159638
Merged
serhiy-storchaka merged 3 commits intoNov 13, 2026
Merged
Conversation
Document.renameNode() set the new prefix of an attribute before its new namespace, so the prefix was validated against the old namespace. Renaming an attribute with no namespace to a prefixed name in a namespace raised NamespaceErr after the attribute had been removed from its element. Set the namespace first, and check the prefix before removing the attribute, so that a rejected rename leaves the element unchanged.
Contributor
Author
|
@serhiy-storchaka, could you take a look when you have a moment? It fixes a regression from GH-156666. |
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
LGTM, but could you please added test for renaming an element node?
Contributor
Author
|
Thanks, done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document.renameNode()now sets the new namespace of an attribute before its prefix, so the prefix is checked against the namespace it is being renamed into. The prefix is also checked before the attribute is removed from its element, so a rejected rename leaves the element unchanged.minidomrenameNode()drops an attribute renamed to a prefixed nameΒ #159637