You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(orch): prefer active PR over branch history - #804
Replaces #684 by @rudycelekli. This is the same commit, rebased onto current main. The author stays Rudy Celekli.
The fork branch could not take the rebase. The rebase brings in main's newer .github/workflows/validate-plugins.yml, and GitHub refuses that workflow update on a fork from an app without the workflows permission. A fork PR's CI also waits for maintainer approval, so this branch on cursor/plugins lets CI run.
Problem
After a stacker closes an obsolete PR and creates a replacement from the same branch, orch frontier set rejects that branch because its all-state forge query returns both PRs. The suggested recovery, closing stale PRs, cannot clear the error because closed rows are still included.
Change
Prefer the sole OPEN PR when selecting a branch anchor. Keep closed and merged anchors when no active PR exists, and continue to reject multiple active PRs. GitHub and Origin use the same policy. The Claude Code harness copy is regenerated.
Verification on the rebased tree
node scripts/validate-plugins.mjs: all plugins validated.
node scripts/generate-pstack-harness-trees.mjs --check: up to date.
node scripts/check-pstack-docs.mjs: 0 problems.
bun test in pstack/skills/poteto-mode/scripts: 72 pass, 0 fail. bun run typecheck (strict): exit 0.
node --test pstack/skills/*/scripts/test/*.test.mjs: 58 pass, 0 fail, 92 skipped (no TLC on this machine).
The reason will be displayed to describe this comment to others. Learn more.
Historical fallback rejects merged replacements
Medium Severity · Logic Bug
When a branch has no OPEN pull request, branchPullRequest falls back to every historical row and still errors if more than one remains. After the replacement this change accepts later merges, orch frontier set fails walking that branch, and closing stale PRs cannot clear it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #684 by @rudycelekli. This is the same commit, rebased onto current main. The author stays Rudy Celekli.
The fork branch could not take the rebase. The rebase brings in main's newer
.github/workflows/validate-plugins.yml, and GitHub refuses that workflow update on a fork from an app without theworkflowspermission. A fork PR's CI also waits for maintainer approval, so this branch oncursor/pluginslets CI run.Problem
After a stacker closes an obsolete PR and creates a replacement from the same branch,
orch frontier setrejects that branch because its all-state forge query returns both PRs. The suggested recovery, closing stale PRs, cannot clear the error because closed rows are still included.Change
Prefer the sole OPEN PR when selecting a branch anchor. Keep closed and merged anchors when no active PR exists, and continue to reject multiple active PRs. GitHub and Origin use the same policy. The Claude Code harness copy is regenerated.
Verification on the rebased tree
node scripts/validate-plugins.mjs: all plugins validated.node scripts/generate-pstack-harness-trees.mjs --check: up to date.node scripts/check-pstack-docs.mjs: 0 problems.bun testinpstack/skills/poteto-mode/scripts: 72 pass, 0 fail.bun run typecheck(strict): exit 0.node --test pstack/skills/*/scripts/test/*.test.mjs: 58 pass, 0 fail, 92 skipped (no TLC on this machine).No pstack version change.