You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Replaces #672 by @rudycelekli. This is the same commit, rebased onto current main. The author stays Rudy Celekli.
The fork branch could not take the rebase. The rebase brings in main's newer .github/workflows/validate-plugins.yml, and GitHub refuses that workflow update on a fork from an app without the workflows permission. A fork PR's CI also waits for maintainer approval, so this branch on cursor/plugins lets CI run.
Problem
The plan checker strips only single-backtick spans before it checks prose punctuation. A valid Markdown inline literal such as echo `x`: y leaves the colon outside the stripped fragments and fails verification. Smart quotes and dashes in the same literal also produce false failures.
Change
Match opening and closing backtick runs of the same length, with run boundaries, so embedded shorter runs remain part of the literal. Unmatched delimiters and surrounding prose stay subject to the existing checks. The Claude Code harness copy is regenerated. This covers inline code spans separately from the fenced code block handling in #536.
Verification on the rebased tree
node scripts/validate-plugins.mjs: all plugins validated.
node scripts/generate-pstack-harness-trees.mjs --check: up to date.
node scripts/check-pstack-docs.mjs: 0 problems.
bun test in pstack/skills/poteto-mode/scripts: 70 pass, 0 fail. bun run typecheck (strict): exit 0.
node --test pstack/skills/*/scripts/test/*.test.mjs: 58 pass, 0 fail, 92 skipped (no TLC on this machine).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #672 by @rudycelekli. This is the same commit, rebased onto current main. The author stays Rudy Celekli.
The fork branch could not take the rebase. The rebase brings in main's newer
.github/workflows/validate-plugins.yml, and GitHub refuses that workflow update on a fork from an app without theworkflowspermission. A fork PR's CI also waits for maintainer approval, so this branch oncursor/pluginslets CI run.Problem
The plan checker strips only single-backtick spans before it checks prose punctuation. A valid Markdown inline literal such as
echo `x`: yleaves the colon outside the stripped fragments and fails verification. Smart quotes and dashes in the same literal also produce false failures.Change
Match opening and closing backtick runs of the same length, with run boundaries, so embedded shorter runs remain part of the literal. Unmatched delimiters and surrounding prose stay subject to the existing checks. The Claude Code harness copy is regenerated. This covers inline code spans separately from the fenced code block handling in #536.
Verification on the rebased tree
node scripts/validate-plugins.mjs: all plugins validated.node scripts/generate-pstack-harness-trees.mjs --check: up to date.node scripts/check-pstack-docs.mjs: 0 problems.bun testinpstack/skills/poteto-mode/scripts: 70 pass, 0 fail.bun run typecheck(strict): exit 0.node --test pstack/skills/*/scripts/test/*.test.mjs: 58 pass, 0 fail, 92 skipped (no TLC on this machine).No pstack version change.